Added extra Prop for Gallery, to assign any prop directly to lightbox.#121
Merged
benhowell merged 2 commits intobenhowell:masterfrom May 26, 2019
JimishF:master
Merged
Added extra Prop for Gallery, to assign any prop directly to lightbox.#121benhowell merged 2 commits intobenhowell:masterfrom JimishF:master
benhowell merged 2 commits intobenhowell:masterfrom
JimishF:master
Conversation
`lightBoxProps`, which is spread over `<LightBox />` component. So It will be easy to add those props to LightBox Directly which are not hardcoded in.
JimishF
changed the title
JimishF
changed the title
Owner
|
Merged. I'll try to push a release at the end of the week. Thanks! |
Owner
|
Apologies for the delay. Published in v0.5.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lightBoxPropsobject is a new prop for Gallery Component, which has been spread over<LightBox />component. So It will be easy to add those props to LightBox Directly which are not hardcoded in.